Fix typo#3247
Closed
milosa wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
=======================================
Coverage 57.99% 57.99%
=======================================
Files 302 302
Lines 21748 21748
=======================================
Hits 12613 12613
Misses 8212 8212
Partials 923 923 |
thaJeztah
requested changes
Aug 12, 2021
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
Thanks! The change itself looks OK, but I see the commit is missing a DCO sign-off, which makes CI fail the failure shows some instructions on fixing that (unfortunately, it requires the commit to be amended on the CLI, and cannot be done through the GitHub web UI); https://github.com/docker/cli/pull/3247/checks?check_run_id=3312135659
When signing-off, make sure to use your real name (not the GitHub handle)
https://github.com/docker/cli/blob/master/CONTRIBUTING.md#sign-your-work
Let me know if you need help!
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.